Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsvg 1.7.0 to eclipse-sdk target #2776

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

HannesWell
Copy link
Member

Comment on lines +96 to +101
<dependency>
<groupId>com.github.weisj</groupId>
<artifactId>jsvg</artifactId>
<version>1.7.0</version>
<type>jar</type>
</dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add this to a dedicated location for better separation?
On the other hand, the settings for this location are perfectly fine.

@HannesWell
Copy link
Member Author

/request-license-review

Copy link
Contributor

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/12938486090

@HannesWell
Copy link
Member Author

  • maven/mavencentral/com.github.weisj/jsvg/1.7.0

This is unfortunately still await manual approval from the IP-team.

@HannesWell
Copy link
Member Author

License review requests:

* [maven/mavencentral/com.github.weisj/jsvg/1.7.0](https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/19179)

The license vetting is finally completed successfully.
I assume that eclipse-platform/eclipse.platform.swt#1638, will not land in this development-cycle but I assume we can still add this now, even if it's not used immediately, can't we?

@HannesWell HannesWell merged commit f4c075b into eclipse-platform:master Feb 6, 2025
4 checks passed
@HannesWell HannesWell deleted the add-jsvg branch February 6, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant